[flutter_inappwebview] Introduce flutter_inappwebview_tizen#1015
[flutter_inappwebview] Introduce flutter_inappwebview_tizen#1015JSUYA wants to merge 4 commits intoflutter-tizen:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the flutter_inappwebview_tizen package, providing a Tizen implementation for the flutter_inappwebview plugin using the EWK API. The implementation supports core features such as URL loading, JavaScript evaluation, and offscreen rendering via a TBM surface buffer pool. Feedback on the native C++ implementation identifies a potential memory leak regarding the management of string allocations for HTTP headers.
JSUYA
force-pushed
the
flutter_inappwebview_tizen
branch
3 times, most recently
from
9214876 to
29d9cee
Compare
JSUYA
force-pushed
the
flutter_inappwebview_tizen
branch
from
29d9cee to
79c335c
Compare
There was a problem hiding this comment.
Code Review
This pull request introduces the flutter_inappwebview_tizen plugin, providing a Tizen implementation for the flutter_inappwebview package. The changes include the necessary plugin infrastructure, Tizen-specific platform implementation using the EWK API, and an example application. Review feedback identified a memory leak in the touch event handling logic, a potential issue with automatic JSON decoding of JavaScript evaluation results, and a suggestion to use specific error codes in error reporting.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds the Tizen implementation for the flutter_inappwebview plugin, featuring offscreen rendering using the EWK API. The native C++ implementation manages WebView instances and buffer pools for texture integration. Review feedback highlights stability concerns, including race conditions in the resizing and buffer management methods, potential crashes, and resource leaks of Ecore_Evas objects. Suggestions also include ensuring one-time initialization of EWK arguments and transitioning to a multi-buffer pool to improve rendering performance.
|
The stabilization work applied to this task will also be applied to webview_flutter. |
1 participant
Introduce
flutter_inappwebview_tizen, the Tizen implementation offlutter_inappwebview.Like
webview_flutter_tizen, it is built on top of EWK (chromium-efl) andrenders offscreen via a TBM surface buffer pool. Only the surface that maps
cleanly onto the Tizen WebView is implemented; APIs that have no EWK
counterpart raise
UnsupportedError/UnimplementedError.+#1008